search

universal-ctags / citre

A superior code reading & auto-completion tool with pluggable backends.
GNU General Public License v3.0
320 stars 26 forks source link

global, fix: correct filename for tramp with global #164

Closed norris-young closed 5 months ago

norris-young commented 6 months ago

We should only pass localpart of tramp files for global argument.

AmaiKinono commented 6 months ago

Thanks a lot for contributing!

Other than the requested change, we also need to put some declare-function lines like

(declare-function tramp-dissect-file-name "tramp" (name &optional nodefault))

to make the byte compiler happy. You could refer to citre-tags.el. Please put these under the ;;;;; Internals section.

You could run make locally to run the tests.

norris-young commented 5 months ago

Thanks a lot for contributing!

Other than the requested change, we also need to put some declare-function lines like

(declare-function tramp-dissect-file-name "tramp" (name &optional nodefault))

to make the byte compiler happy. You could refer to citre-tags.el. Please put these under the ;;;;; Internals section.

You could run make locally to run the tests.

I tried make with following errors. I have no idea whether it has relationships with my patch.

Ran 5 tests, 0 results as expected, 5 unexpected (2024-02-03 11:51:40+0800, 0.478963 sec)

5 unexpected results:
   FAILED  test-lang-c-callable-sorting
   FAILED  test-lang-c-goto-sorting
   FAILED  test-lang-c-header-sorting
   FAILED  test-lang-c-member-sorting
   FAILED  test-lang-c-struct-tag-sorting

[test] A test in tests/tags-lang-c failed.
make: *** [Makefile:11: test] Error 1
AmaiKinono commented 5 months ago

Thanks!

I tried make with following errors.

This should because you don't have ctags and readtags installed on your machine. I may need to change the test harness to make it not bother contributes who don't have certain programs installed.