Closed masatake closed 3 years ago
Thanks for the patch!
I don't quite like the idea of making use of xref
(the marker
and extra-move
things is really, really smart, though). What do you think of this way:
citre-get-definitions
to get a list of tags.The (de)serialization can be done with:
(defun citre--print-value-to-file (filename value)
"Print VALUE to file FILENAME."
(with-temp-file filename
(prin1 value (current-buffer))))
(defun citre--read-value-from-file (filename)
"Read value from file FILENAME."
(with-temp-buffer
(insert-file-contents filename)
(goto-char (point-min))
(read (current-buffer))))
I don't have experience of comparing hash tables, though. I think what we can do is:
input
field in the tags.I will rework this item.
Updated.
I used citre-get-definitions
as you wrote. I agree that using citre-get-definitions
is much better than extracting the contents of xref buffer.
However, I think using the contents of xref buffer as expected output is very intuitive for developers of test cases.
So I defined defs-to-xref
in test.el and use it.
Thanks for your beautiful work ;)
This change is for testing the code newly added in #52.