search

universal-ctags / ctags

A maintained ctags implementation
https://ctags.io
GNU General Public License v2.0
6.51k stars 622 forks source link

Update kotlin parser #3841

Closed dolik-rce closed 11 months ago

dolik-rce commented 11 months ago

There has been a few small improvements to the Kotlin language specification this year, so it's time to update the grammar for the kotlin parser.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (35abbb1) 85.05% compared to head (a41827e) 85.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3841 +/- ## ======================================= Coverage 85.05% 85.05% ======================================= Files 228 228 Lines 53982 53982 ======================================= Hits 45914 45914 Misses 8068 8068 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

masatake commented 11 months ago

@dolik-rce Thank you. Don't we need a test case for the change?

dolik-rce commented 11 months ago

@masatake: I don't think so. The changes are really minor and the existing tests only check basic kotlin syntax.

It might be good idea to try to compose a kotlin file that would cover all the rules, but it would be quite big and tedious to construct, so it wouldn't fit into this PR.

masatake commented 11 months ago

@dolik-rce I see. Thank you.