build-sys: don't use libxml-2 if its CRLF handling is broken

universal-ctags / ctags

A maintained ctags implementation

https://ctags.io

GNU General Public License v2.0

6.57k stars 627 forks source link

build-sys: don't use libxml-2 if its CRLF handling is broken #3858

Closed masatake closed 11 months ago

masatake commented 12 months ago

See #3851 .

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fae067a) 85.02% compared to head (600075f) 85.02%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3858 +/- ## ======================================= Coverage 85.02% 85.02% ======================================= Files 228 228 Lines 53901 53901 ======================================= Hits 45832 45832 Misses 8069 8069 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

masatake commented 12 months ago

??? Why the errors of the test case is not reproduced?

masatake commented 12 months ago

It seems that I must cherry-pick #3854.

masatake commented 12 months ago

The input for the failed case uses CR+LF as the line separator. In cc24c85, I added a new test case cloned from the test case with changing the line separator to LF. The cloned test case didn't fail.