universal-ctags / ctags

A maintained ctags implementation
https://ctags.io
GNU General Public License v2.0
6.57k stars 627 forks source link

Revise the release process #3894

Closed masatake closed 11 months ago

masatake commented 11 months ago

Close #3767.

masatake commented 11 months ago

@leleliu008 could you review f94bdfa ? See #3767.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4871bfc) 85.29% compared to head (53c0e97) 85.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3894 +/- ## ======================================= Coverage 85.29% 85.29% ======================================= Files 232 232 Lines 55786 55786 ======================================= Hits 47582 47582 Misses 8204 8204 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leleliu008 commented 11 months ago

If we want to display something like github-actions tagged this, we need to use github-cli I guess, if we use git command, github would display universal-ctags tagged this, because tagger's email Universal-ctags@users.noreply.github.com belongs to universal-ctags account.

masatake commented 11 months ago

@leleliu008 Thank you.

I don't want to make an annotation tag for a snapshot. So displaying the HEAD commit's commiter is ok. I don't want to increase the number of commits just for making snapshots.

At the initial comment in #3767, you wrote:

If you think current is good enough, I think we should remove the Universal-ctags CI and Universal-ctags@users.noreply.github.com or add more comments.

I implemented what I wrote here in f94bdfa. Do I misunderstand what you wrote?

leleliu008 commented 11 months ago

@masatake There is no misunderstandings.

masatake commented 11 months ago

@leleliu008 Thank you for confirmation. I will remove the comments newly added in this pull request.