universal-ctags / ctags

A maintained ctags implementation
https://ctags.io
GNU General Public License v2.0
6.51k stars 622 forks source link

lex: add support for implementation blocks of conditions #3937

Closed jafl closed 7 months ago

jafl commented 7 months ago

In some lexers, all the rules for a condition are grouped together as: { ... }

It is useful to be able to jump to these blocks.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c26e151) 85.38% compared to head (252e692) 85.38%.

Files Patch % Lines
optlib/lex.c 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3937 +/- ## ========================================== - Coverage 85.38% 85.38% -0.01% ========================================== Files 234 234 Lines 56200 56201 +1 ========================================== Hits 47987 47987 - Misses 8213 8214 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

masatake commented 7 months ago

I wonder whether we should capture it as a definition or reference tag.

Tagging B_ENVIRONMENT as grouping role of condition kind is my alternative idea.

masatake commented 7 months ago

I wonder whether we should capture it as a definition or reference tag.

jafl commented 7 months ago

I wonder whether we should capture it as a definition or reference tag.

How would that change the code and the output?

masatake commented 7 months ago

How would that change the code and the output?

I'll make a pull request based on your pull request to demonstrate tagging ' {..}` with a reference tag. Please, give me time. I have trouble with my health.

jafl commented 7 months ago

Closing in favor of #3939

jafl commented 7 months ago

And I hope you feel better soon!