universal-ctags / ctags

A maintained ctags implementation
https://ctags.io
GNU General Public License v2.0
6.39k stars 618 forks source link

Terraform: fix two known bugs #3945

Closed ponchoalv closed 4 months ago

ponchoalv commented 4 months ago

This release will fix two know bugs:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 85.35%. Comparing base (6406cb3) to head (e98c847).

Files Patch % Lines
optlib/terraform.c 0.00% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3945 +/- ## ========================================== - Coverage 85.38% 85.35% -0.04% ========================================== Files 234 234 Lines 56204 56226 +22 ========================================== Hits 47989 47989 - Misses 8215 8237 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ponchoalv commented 4 months ago

@masatake thank you for the quickly review 🙇‍♂️! just pushed the suggested changes

masatake commented 4 months ago

I have one more request. Could you squash the two commits into one? And, could you use the following text as the commit log for the squashed commit:

terraform: switch to multi-table ctags regex

This release will fix two know bugs:

- [x] The parser doesn't ignore strings inside a block comment (``/* ... */``).

- [x] The parser doesn't extract variables defined with ``locals`` keyword.

Update the parser version to 1.1

The last line helps me to update our NEWS file when I release a new version of ctags.

masatake commented 4 months ago

Thank you.