Closed ponchoalv closed 4 months ago
Attention: Patch coverage is 0%
with 28 lines
in your changes are missing coverage. Please review.
Project coverage is 85.35%. Comparing base (
6406cb3
) to head (e98c847
).
Files | Patch % | Lines |
---|---|---|
optlib/terraform.c | 0.00% | 28 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@masatake thank you for the quickly review 🙇♂️! just pushed the suggested changes
I have one more request. Could you squash the two commits into one? And, could you use the following text as the commit log for the squashed commit:
terraform: switch to multi-table ctags regex
This release will fix two know bugs:
- [x] The parser doesn't ignore strings inside a block comment (``/* ... */``).
- [x] The parser doesn't extract variables defined with ``locals`` keyword.
Update the parser version to 1.1
The last line helps me to update our NEWS file when I release a new version of ctags.
Thank you.
This release will fix two know bugs:
[x] The parser doesn't ignore strings inside a block comment (
/* ... */
).[x] The parser doesn't extract variables defined with
locals
keyword.