universal-ctags / ctags

A maintained ctags implementation
https://ctags.io
GNU General Public License v2.0
6.39k stars 618 forks source link

GitHub Actions: set HOMEBREW_NO_INSTALL_CLEANUP #3954

Closed masatake closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.37%. Comparing base (38fd8e3) to head (edbe46f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3954 +/- ## ======================================= Coverage 85.37% 85.37% ======================================= Files 235 235 Lines 56458 56458 ======================================= Hits 48200 48200 Misses 8258 8258 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leleliu008 commented 3 months ago

You do not need to set that, that already has been done for you. https://github.com/actions/runner-images/issues/2466

masatake commented 3 months ago

@leleliu008 Thank you. How can we avoid the failure on "run units target on macOS / testing (macos-13) (pull_request)" ?

leleliu008 commented 3 months ago
brew install --overwrite python@3.12
masatake commented 3 months ago

However, I found the following comment that you wrote in testing-mac.yml:

    # NOTE: DO NOT try to install python3 package via brew, it has already been included in macos-xx runner images

Should I delete the comment and add brew install --overwrite python@3.12 instead?

leleliu008 commented 3 months ago

There are many python packages like python@3.10 python@3.11 python@3.12 in brew, they always conflict with each other.

masatake commented 3 months ago

??? So what should we do? Should we specify the version of Python explicitly, though a version of Python has already been included in macos-xx runner images?

leleliu008 commented 3 months ago

However, I found the following comment that you wrote in testing-mac.yml:

    # NOTE: DO NOT try to install python3 package via brew, it has already been included in macos-xx runner images

Should I delete the comment and add brew install --overwrite python@3.12 instead?

we do not install a python package though, but many packages may depend on different version of python packages. HomeBrew Team update their package formula frequently, it's very unstable, but it usually canbe fix via brew install --overwrite python@x.y

leleliu008 commented 3 months ago

??? So what should we do? Should we specify the version of Python explicitly, though a version of Python has already been included in macos-xx runner images?

Yes, no good solution. It is not a stable package manager after all.

leleliu008 commented 3 months ago

let me fix it. I will file a new PR to fix it.

leleliu008 commented 3 months ago

fixed as https://github.com/universal-ctags/ctags/pull/3955