search

universal-ctags / homebrew-universal-ctags

Homebrew Tap for Universal Ctags on OSX
https://ctags.io
GNU General Public License v2.0
326 stars 19 forks source link

Address some deprecation warnings #11

Closed wendorf closed 7 years ago

wendorf commented 8 years ago

I noticed a deprecation warning when running brew outdated:

Warning: Calling 'depends_on :autoconf' is deprecated!
Use 'depends_on "autoconf"' instead.
/usr/local/Library/Taps/universal-ctags/homebrew-universal-ctags/universal-ctags.rb:4:in `<class:UniversalCtags>'
Please report this to the universal-ctags/universal-ctags tap!

Warning: Calling 'depends_on :automake' is deprecated!
Use 'depends_on "automake"' instead.
/usr/local/Library/Taps/universal-ctags/homebrew-universal-ctags/universal-ctags.rb:5:in `<class:UniversalCtags>'
Please report this to the universal-ctags/universal-ctags tap!

and decided to fix some of the errors reported by brew audit --strict --online universal-ctags. There are still two errors:

universal-ctags/universal-ctags/universal-ctags:
  * Head-only (no stable download)
  * Formula should have a desc (Description).

but they're less-cosmetic, so I did not address them.

wendorf commented 8 years ago

Just noticed #8, which took care of the main point of this, so I rebased on top of that to fix the other minor warnings.

cweagans commented 8 years ago

8 is now merged. Can you strip this down to just wrapping strings in quotes? I'm not sure about the other changes, particularly the addition of => :build. I need to play with it a bit before I can merge that, as I think it may change the behavior of this formula in a potentially undesirable way. It's not a no, but I definitely want to look into it before merging. The string quoting is an obvious win, though.

wendorf commented 7 years ago

I've reduced this to just the quotes change, and have rebased on master.

KazuakiM commented 7 years ago

merged #15 . Thank you.