Closed KazuakiM closed 7 years ago
Hi, @cweagans I would like you to review my code.
Seems reasonable to me, but I no longer have a mac so I can't test.
Can you find someone to test, comment here, and if everything is good, I'll merge it?
OK. I think some options was added by this PR.
$ ctags --help
--input-encoding=encoding
Specify encoding of all input files.
--input-encoding-<LANG>=encoding
Specify encoding of the LANG input files.
--output-encoding=encoding
The encoding to write the tag file in. Defaults to UTF-8 if --input-encoding
brew uninstall universal-ctags
brew untap universal-ctags/universal-ctags
You can check repository at https://github.com/KazuakiM/homebrew-universal-ctags .
brew install --HEAD KazuakiM/universal-ctags/universal-ctags
brew uninstall universal-ctags
brew untap KazuakiM/universal-ctags
brew install --HEAD universal-ctags/universal-ctags/universal-ctags
Fixed typo comments.
How about this?
Hi @wendorf , Could you review it?
lgtm
Thank you, @wendorf . Hi, @cweagans We confirmed the source code.
@cweagans:
Seems reasonable to me, but I no longer have a mac so I can't test.
Oh, thats' a bad news.
I don't know MacOS but doen't runnting test on Travis help? If I understand correctly, encoding options are tested on MacOS on Travis.
@wendorf and @KazuakiM, I guess you are expoerts of MacOS. How do you think spending your valuable time for improving Universal-ctags?
I'm afraid that we get a bug report about ctags running on MacOS.
@masatake : I'll write test codes. Please give me some time.
@masatake : Hi, I add PR #22 .
@KazuakiM, I'm sorry but I don't have enough knowledge about these areas. @cweagans, could you look #22 ? If both you are o.k, I think it is better to invite @KazuakiM to this project.
That's alright with me. The more the merrier.
Did icov default support? If so, I will close this PR.
Recently I changed to enable it by default.
@k-takata thank you so much!!
Just FYI, the PR is universal-ctags/ctags#1405.
That's alright with me. The more the merrier.
Thank you.
@KazuakiM, how about you?
@masatake I want to join this project.
@KazuakiM, I think I sent an invitation to you. I hope you get it.
@masatake Thank you. I got authority to commit this repository.
Mac has icov installed by default. If it doesn't hurt, how is it effective by default? If there seems to be a problem, I'd like to give another PR again in Options.