universal-ctags / homebrew-universal-ctags

Homebrew Tap for Universal Ctags on OSX

https://ctags.io

GNU General Public License v2.0

326 stars 19 forks source link

Enable iconv #19

Closed KazuakiM closed 7 years ago

KazuakiM commented 7 years ago

Mac has icov installed by default. If it doesn't hurt, how is it effective by default? If there seems to be a problem, I'd like to give another PR again in Options.

KazuakiM commented 7 years ago

Hi, @cweagans I would like you to review my code.

cweagans commented 7 years ago

Seems reasonable to me, but I no longer have a mac so I can't test.

cweagans commented 7 years ago

Can you find someone to test, comment here, and if everything is good, I'll merge it?

KazuakiM commented 7 years ago

OK. I think some options was added by this PR.

$ ctags --help
  --input-encoding=encoding
      Specify encoding of all input files.
  --input-encoding-<LANG>=encoding
      Specify encoding of the LANG input files.
  --output-encoding=encoding
      The encoding to write the tag file in. Defaults to UTF-8 if --input-encoding

following

Uninstall universal-ctags/universal-ctags

brew uninstall universal-ctags
brew untap universal-ctags/universal-ctags

Install KazuakiM/universal-ctags

You can check repository at https://github.com/KazuakiM/homebrew-universal-ctags .

brew install --HEAD KazuakiM/universal-ctags/universal-ctags

Uninstall KazuakiM/universal-ctags

brew uninstall universal-ctags
brew untap KazuakiM/universal-ctags

Install universal-ctags/universal-ctags

brew install --HEAD universal-ctags/universal-ctags/universal-ctags

KazuakiM commented 7 years ago

Fixed typo comments.

KazuakiM commented 7 years ago

How about this?

KazuakiM commented 7 years ago

Hi @wendorf , Could you review it?

wendorf commented 7 years ago

lgtm

KazuakiM commented 7 years ago

Thank you, @wendorf . Hi, @cweagans We confirmed the source code.

masatake commented 7 years ago

@cweagans:

Seems reasonable to me, but I no longer have a mac so I can't test.

Oh, thats' a bad news.

I don't know MacOS but doen't runnting test on Travis help? If I understand correctly, encoding options are tested on MacOS on Travis.

@wendorf and @KazuakiM, I guess you are expoerts of MacOS. How do you think spending your valuable time for improving Universal-ctags?

I'm afraid that we get a bug report about ctags running on MacOS.

KazuakiM commented 7 years ago

@masatake : I'll write test codes. Please give me some time.

KazuakiM commented 7 years ago

@masatake : Hi, I add PR #22 .

masatake commented 7 years ago

@KazuakiM, I'm sorry but I don't have enough knowledge about these areas. @cweagans, could you look #22 ? If both you are o.k, I think it is better to invite @KazuakiM to this project.

cweagans commented 7 years ago

That's alright with me. The more the merrier.

KazuakiM commented 7 years ago

Did icov default support? If so, I will close this PR.

k-takata commented 7 years ago

Recently I changed to enable it by default.

KazuakiM commented 7 years ago

@k-takata thank you so much!!

k-takata commented 7 years ago

Just FYI, the PR is universal-ctags/ctags#1405.

masatake commented 7 years ago

That's alright with me. The more the merrier.

Thank you.

@KazuakiM, how about you?

KazuakiM commented 7 years ago

@masatake I want to join this project.

masatake commented 7 years ago

@KazuakiM, I think I sent an invitation to you. I hope you get it.

KazuakiM commented 7 years ago

@masatake Thank you. I got authority to commit this repository.