universal-ctags / homebrew-universal-ctags

Homebrew Tap for Universal Ctags on OSX
https://ctags.io
GNU General Public License v2.0
326 stars 19 forks source link

Use autogen.sh and add automaker dependency #4

Closed choco closed 8 years ago

choco commented 8 years ago

On a fresh OS X installation (10.11.2) I was getting an error related to the autoconf script, this fixes it for me.

splhack commented 8 years ago

:+1:

KazuakiM commented 8 years ago

:+1:

castor4bit commented 8 years ago

:+1:

choco commented 8 years ago

I added new options (and defaults) and removed "deprecated" configuration options. I'd be cool if you guys could test the new version :)

bruschill commented 8 years ago

:+1:

thtb commented 8 years ago

how can i use it now

cweagans commented 8 years ago

A small subset of this was merged in https://github.com/universal-ctags/homebrew-universal-ctags/pull/6 - just the automake dependency and autogen.sh. I'm not 100% sure about the remainder of this PR, but at the very least, it will need to be rerolled without the automake and autogen.sh changes.

zbeekman commented 8 years ago

@cweagans @cHoco: I'd be happy to work up a quick PR to add the options @cHoco added in this PR but are missing from #6.

Also, the dependency on autoconf and automake should probably be listed as a build dependency so that if bottles are ever provided (as they are when a formula is merged into the main homebrew repository) users can install from the bottled version without needing to download and build/install autoconf and automake.

cweagans commented 8 years ago

@zbeekman If you'd like to do that, I'd appreciate it! :)

Personally, I'd like to see that split into a few PRs:

Sorry for the granularity. Just makes it easier to revert individual changes if we need to, and makes things much easier to track.

cweagans commented 8 years ago

Also, closing for now. Thanks for opening this, @cHoco!