universal-vue / uvue

Vue CLI plugin to create universal Vue applications with ease
https://universal-vue.github.io/docs/
MIT License
127 stars 13 forks source link

Property 'client' does not exist on type 'Process' #30

Closed academici closed 5 years ago

academici commented 5 years ago

Describe the bug

ERROR in /home/vostrikov/site/src/registerServiceWorker.ts

5:54 Property 'client' does not exist on type 'Process'.
    3 | import { register } from "register-service-worker";
    4 | 
  > 5 | if (process.env.NODE_ENV === "production" && process.client) {
      |                                                      ^
    6 |   register(`${process.env.BASE_URL}service-worker.js`, {
    7 |     ready() {
    8 |       console.log(

To Reproduce Create vue cli project with all features, sass (dart) preprocessor Add ssr plugin Run ssr:fix and ssr:fix-vuex Run ssr:build

Additional context

Please indicate versions of:

node: 11.12.0
vue-cli: 3.5.1
uvue: v0.1.0-alpha.18
os: ubuntu 18.04
browser: chrome 72
academici commented 5 years ago

When server is running get an error:

{"level":50,"time":1552736025593,"msg":"navigator is not defined","pid":27483,"hostname":"dmitry-desktop","type":"Error","stack":"ReferenceError: navigator is not defined\n    at ce (server-bundle.js:1:14947)\n    at Module.de6b (server-bundle.js:1:15910)\n    at n (server-bundle.js:1:196)\n    at Object.0 (server-bundle.js:1:1318)\n    at n (server-bundle.js:1:196)\n    at module.exports.0 (server-bundle.js:1:1279)\n    at Object.<anonymous> (server-bundle.js:1:1288)\n    at o (/home/vostrikov/site/node_modules/vue-server-renderer/build.prod.js:1:77379)\n    at /home/vostrikov/site/node_modules/vue-server-renderer/build.prod.js:1:77972\n    at new Promise (<anonymous>)","v":1}
yabab-dev commented 5 years ago

Can you test this, as workaround:

Create a file src/types.d.ts, with this code:

import '@uvue/core';
yabab-dev commented 5 years ago

You can do this too:

In tsconfig.json:

{
  "compilerOptions": {
    "types": ["webpack-env", "@uvue/core"],
  }
}
yabab-dev commented 5 years ago

Fixed in 0.1.0-alpha.19