search

universalcore / springboard

Bootstrap Universal Core applications easily
http://springboard.readthedocs.org/
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

use `Model` instances instead of `MappingType` instances #24

Open Rizziepit opened 9 years ago

Rizziepit commented 9 years ago

Is there a reason we are not using the MappingType.to_object method to convert to model instances, e.g. https://github.com/universalcore/springboard/blob/develop/springboard/views.py#L63?

I want to prevent future issues when schemas change.

Rizziepit commented 9 years ago

@miltontony @smn is this issue valid?

smn commented 9 years ago

No, the only reason that's not used is because when this was writing the only option available was to either hit Git or work with whatever ES returned.

smn commented 9 years ago

So, yes, this issue is valid :)