search

universalcore / springboard

Bootstrap Universal Core applications easily
http://springboard.readthedocs.org/
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Enable usage of ElasticGit's shiny new RemoteWorkspace #25

Closed smn closed 9 years ago

smn commented 9 years ago

Not at all ready for review.

Rizziepit commented 9 years ago

@smn @miltontony can you give me a small review or feedback? Particularly this stuff:

  1. The import command can import a repo remotely if you specify --host. All other commands are for local use only.
  2. The search class SM handles remote repos using RepoHelper (that's a new elastic-git thing). I've added CachingRepoHelper in springboard to cache active branch names for the duration of a request. Otherwise springboard makes 20+ repo GET requests to unicore.distribute for the home page.
  3. How should api_notify work for remote repos?

This is almost done. Just checking if I need to change direction before writing tests.

miltontony commented 9 years ago

:+1: with just a note on the fastforward that it should do a POST to UCD

Rizziepit commented 9 years ago

@miltontony all done. final review?

miltontony commented 9 years ago

:+1: