search

universam1 / iSpindel

electronic Hydrometer
http://www.ispindel.de
Other
827 stars 322 forks source link

Temperature Adjustment Feature #440

Closed thegreatgunbantoad closed 3 years ago

thegreatgunbantoad commented 3 years ago

Allows the raw sensor value to be adjusted based on the calculation in the Config screen of the AP. Calculation is done on the scaled version of temp so that +1 would add 1 decC, 1 degF or 1degK based on what the unit is setup for.

thegreatgunbantoad commented 3 years ago

@universam1 just a quick poke

thegreatgunbantoad commented 3 years ago

@ErikdBr are you up to giving this a review? Don't know how your C++ is.

ErikdBr commented 3 years ago

@ErikdBr are you up to giving this a review? Don't know how your C++ is.

I can read it, will take a look at it tomorrow, as it is 23.00 hours overhere.

thegreatgunbantoad commented 3 years ago

@ErikdBr are you up to giving this a review? Don't know how your C++ is.

I can read it, will take a look at it tomorrow, as it is 23.00 hours overhere.

Cheers.

ErikdBr commented 3 years ago

@ErikdBr are you up to giving this a review? Don't know how your C++ is.

I can read it, will take a look at it tomorrow, as it is 23.00 hours overhere.

Cheers.

Have to postpone to tomorrow, sorry.

thegreatgunbantoad commented 3 years ago

I reviewed the code and didn't see any faults. However I am not able tot test it.

Thank you for looking.

the code has worked fine for me.

Just need @universam1 to decide if he want's to take the code or not.

thegreatgunbantoad commented 3 years ago

@universam1 any thoughts on weather or not you want to incorporate this?

thegreatgunbantoad commented 3 years ago

@universam1 This is to allow the temp sensor reading to be adjusted and essentially calibrated. Nothing to do with Gravity really.

pppedrillo commented 3 years ago

DS18B20 sensor has +-0.5c accuracy and does not require any sort of calibrations. http://datasheets.maximintegrated.com/en/ds/DS18B20.pdf

Capture

thegreatgunbantoad commented 3 years ago

@pppedrillo some of the ones off eBay are clones I think and they do vary a bit compared to the real thing. I have yet to properly profile this though as I can't find my K-Type thermocouple at the moment.

pppedrillo commented 3 years ago

@thegreatgunbantoad Ahh, I see. Then it make sense. While chasing all the ghosts from aliexpress (dodgy gyros, wemoses, temp probes etc) with software fixes may be a tedious task.

universam1 commented 3 years ago

I also second that point of @pppedrillo that they are calibrated by manufacturers and I doubt the majority has more precise sensors available at home.

In case if clones exist then there are other issues as well like communication problems, unexpected ids and so forth. Hence I’d rather add a note to be alert on such cheap clones sand avoid them by all means, because we cannot cover for all of their potential problems and we do not want to encourage that counterfeit business model as well

thegreatgunbantoad commented 3 years ago

There's so little way of telling if they are counterfeit these days. I believe the ones I have to be real, but I do see more variability in them than I'd like. Left in air my thermocouple reads 19.5 C and two iSpindels report 21.5 and 21.9. That's a full 2 C out. Then again I have one in a fermenter that's at 17.6 (Inkbird and the thermocouple agree on that) reading 17.9 which is very close. Might have to chuck a couple in an ice bath and see what they read.

universam1 commented 3 years ago

The influence I cannot stress enough is the self heating during continuous run of the ESP.

Always take the temperature with a grain of salt while in AP mode, don't underestimate the influence of MCU heat dissipation.

It will only be accurate when in normal mode, when the intervals are longer than ~5min. Cant be stressed enough.

pppedrillo commented 3 years ago

The influence I cannot stress enough is the self heating during continuous run of the ESP.

I agree with @universam1 on this. Especially if you have your test ispindels inside closed vials. Are they the same amount off if you take the assemblies out of vials?

thegreatgunbantoad commented 3 years ago

Running in normal mode at 15mins reporting to BF, one in a vial one out and temperature soaked for an hour. All put close together, no particular draughts in the room.