universam1 / iSpindel

electronic Hydrometer
http://www.ispindel.de
Other
827 stars 322 forks source link

Increased the maximum size of the polynomial parameter #453

Closed niki77 closed 3 years ago

niki77 commented 3 years ago

Increased the maximum size of the polynomial parameter from 100 to 250 char

ErikdBr commented 3 years ago

What usually seems to be forgotten is to increase line 23 #define FIRMWAREVERSION "6.5.0" in the globals.h or is that only to be done by @universam1 ?

thegreatgunbantoad commented 3 years ago

I'd be inclined to change the 250 in: WiFiManagerParameter custom_polynom("POLYN", "Polynominal", htmlencode(my_polynominal).c_str(), 250 * 2, WFM_NO_LABEL); to sizeof(my_polynominal) So as to reduce the amount of hard coding

But it's functionally fine as is.