universam1 / iSpindel

electronic Hydrometer
http://www.ispindel.de
Other
827 stars 322 forks source link

HTTP404 when clicking "Delete WiFi configuration and reboot" /r #600

Closed GElkayam closed 1 year ago

GElkayam commented 1 year ago

https://github.com/universam1/iSpindel/blob/22951183beb5d70dbaa782aa87378bdc9019f0e7/pio/lib/WiFiManagerKT/WiFiManagerKT.cpp#L945

universam1 commented 1 year ago

Please describe the issue first

ErikdBr commented 1 year ago

The issue is that when you click the /r link from the maintenance page you get this error: Screenshot_20230114-171711_Chrome

GElkayam commented 1 year ago

Hi @universam1 , @ErikdBr is right, when clicking the /r link, you get a 404. seems that in this commit, /r was changed to /reset (calling handleReset), so just need to align. https://github.com/universam1/iSpindel/commit/e46bed1c341345bd8f53f69c8ae9d4da7b683a98#diff-e99471864a9b9c55df31c591e65a440ea3e22f1869c13667f1eb8254ca492d72L148

Before: https://github.com/universam1/iSpindel/blob/5.6.2/pio/lib/WiFiManagerKT/WiFiManagerKT.cpp#L148 After: https://github.com/universam1/iSpindel/blob/5.7.0/pio/lib/WiFiManagerKT/WiFiManagerKT.cpp#L182

small cosmetic issue.

ErikdBr commented 1 year ago

https://github.com/universam1/iSpindel/blob/22951183beb5d70dbaa782aa87378bdc9019f0e7/pio/lib/WiFiManagerKT/WiFiManagerKT.cpp#L945 And shouldn't this line be: page += F("<tr><td><a href='/reset'>/r</a></td>");

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

GElkayam commented 1 year ago

Hey @universam1 , I see Stalebot closed this issue? care to reopen?

universam1 commented 1 year ago

fix released in 7.2.2