Closed rmitsch closed 6 years ago
@Lumik7 @MoBran Implemented in 0a8d190. It takes a while though despite compiling against Cython and although I added multithreading - currently taking benchmarks.
Suggesting a merge. If there are any obvious performance improvements, we can open up separate issues for them.
Note that this commit requires new dependencies - check requirements.txt
.
Takes about 17 minutes on my laptop for all trips available so far. Think that's decent.
sounds good to me. Haven't done anything with multithreading or cython in python before, so I cannot really suggest any improvements right away, but 17 minutes should be fine
Ad Cython: Me neither, but the code of the module I'm using compiles against Cython (if it's active) at time of module installation. Happens automatically.
Ad multithreading: It's rather easy. If you want to check it out, see def _calculate_distance_with_dtw(data, norm: int = 1)
and DTWThread
.
Merged.
See implementation of n2-norm for template.