univie-datamining-team3 / assignment2

Analysis of mobility data
MIT License
0 stars 0 forks source link

Preprocessing: Combine all preprocessing steps in one method #7

Closed Lumik7 closed 6 years ago

Lumik7 commented 6 years ago

In preprocessing.py create a method preprocess() which calls all required preprocessing steps. The method stub is already in preprocessing.py. This method should be called from make_dataset.py which first downloads the data to the data/raw folder and then applies the preprocessing steps and saves them to data/preprocessed.

rmitsch commented 6 years ago

@Lumik7 @MoBran Following changes in the latest commit:

If there are no objections, I'll merge the current status into master and close this issue.

Lumik7 commented 6 years ago

I agree, but could you update the notebook, so that it is compatible with the code changes?

rmitsch commented 6 years ago

Sorry, forgot about that. Updated now. Should I merge?

Lumik7 commented 6 years ago

Thanks, yes I'm fine with it.

Lumik7 commented 6 years ago

Normalize to same hertz rate should also be included in the Preprocessor.preprocessing() function @MoBran .

Lumik7 commented 6 years ago

close this issue as normalization is included in preprocessing