univlorraine / limesurvey-cas

CAS Authentication plugin for limesurvey (based on phpCAS)
GNU General Public License v2.0
25 stars 23 forks source link

Unable to set ports to none #1

Closed Shnoulle closed 9 years ago

Shnoulle commented 9 years ago

If you have a cas without port (80 is default), setting to empty string replace it by 0. Setting to 80/443 can go to a broken link (unconnect redirect) (tested, but don't know cas configuration).

I think we must allow empty to port.

goyome commented 9 years ago

I agree with you. Empty port shouldn't break the plugin. But considering 80 to be the default port for CAS annoys me for security reason. I would prefer using the default installation port (8443) or the most commonly used one (443). I think I'm going to replace empty CAS port by 443.

About the second part of your message, Setting the port to 80 or 443 should work depending on your server configuration. To validate that your settings are the right ones, you can try to contact your CAS server in your browser using : _CASServer:_CAS_portCASuri/login

The CAS URI setting, if not empty, should start with a slash.

I'll wait for your feedback before updating the code

Shnoulle commented 9 years ago

I ask to the user test with 443 ... maybe we made an error this mornig on testing. But set '' to port seems to fix the issue too ;)

Shnoulle commented 9 years ago

Set to 443 fix it :)

PS: Thanks a lot, great plugin