search

univrsal / JustEnoughButtons

Adds utility buttons to the inventory screen
Mozilla Public License 2.0
6 stars 5 forks source link

1.12.2 non-critical updates and stuff #48

Closed magneticflux- closed 5 years ago

magneticflux- commented 5 years ago

I updated the Forge version, the MCP mappings, and the Gradle wrapper, I added a .gitignore and recommended IDEA project files, and I added a Travis CI config that builds and runs the check task on each commit.

univrsal commented 5 years ago

Does the .idea folder contain any crucial files? Because I wouldn't want it in the repository unless it served a purpose

magneticflux- commented 5 years ago

JetBrains themselves recommend that the folder is checked in here:

All the files under .idea directory in the project root except the workspace.xml, usage.statistics.xml, and tasks.xml files which store user specific settings

They also maintain a .gitignore for JetBrains projects here that follows their guidelines. Right now the files just have empty config options in them for the most part, but it checking them in makes sure developers have a consistent view of the project.

Additionally, since the project is imported from a Gradle project, the .iml files are ignored on these lines (uncommented in this PR).

univrsal commented 5 years ago

Well, thanks again for your contribution

magneticflux- commented 5 years ago

@univrsal 😄 If you want to get CI working, just set up the Travis Ci GitHub app!

univrsal commented 5 years ago

Don't think that's necessary for a project this small