search

univrsal / spectralizer

Audio visualizer plugin for obs-studio
GNU General Public License v2.0
591 stars 58 forks source link

Color Correction filter doesn't work if it's the first in the list #2

Closed WizardCM closed 4 years ago

WizardCM commented 4 years ago

Reproduction steps:

  1. Add an Audio Visualiser source to your scene
  2. Select an audio device so that the visualiser starts moving, then hit OK
  3. Right click the source and select Filters
  4. Click + then select "Color Correction"
  5. Adjust the opacity to 50%. Notice the opacity of the visualiser doesn't change
  6. Add another filter, like Scroll. Place it above the Color Correction filter. This will cause the opacity to go into effect.

OBS Studio v24.0.3 on Windows 10 64bit, using the tagged v1.0.

univrsal commented 4 years ago

Edit: Nevermind, I never knew that I have to add OBS_SOURCE_CUSTOM_DRAW to the output flags of the source. That's why I always had issues with filters.

~Is there a chance that this might be an obs bug? I copied the code 1:1 from color source and the filter still doesn't work:~ image image

univrsal commented 4 years ago

Also I saw you mentioned that the program lacked logging, I put most logging into the debug log because I didn't want to spam the logs. Which parts do you think could use logging?

WizardCM commented 4 years ago

Mostly whether it successfully captured an audio device, or if the audio device has been lost.

univrsal commented 4 years ago

I added logging to the audio source capturing