search

univrsal / tuna

Song information plugin for obs-studio
GNU General Public License v2.0
751 stars 59 forks source link

OBS exits after requesting token for Spotify #131

Closed entriphy closed 3 years ago

entriphy commented 3 years ago

Describe the bug After going through the process to use Spotify with Tuna, OBS exits after pressing the "Request token" button.

To Reproduce

  1. Open Tuna settings and go to the Spotify tab
  2. Press "Open login page" and authenticate Tuna
  3. Copy and paste the authentication code into the authentication code field in OBS
  4. Press "Request token"

Expected behavior OBS does not exit and it successfully gets a token.

Screenshots https://user-images.githubusercontent.com/1747088/120571517-26b56200-c3cf-11eb-8a86-85c98ff9ae94.mp4

Log https://obsproject.com/logs/gXSDzQPvKy24jU9-

Additional context This bug occurs in OBS 26 and 27 when using the latest stable and nightly builds of Tuna. There are no logs in the crashes directory.

Tipyx commented 3 years ago

I experienced this too after a clean reinstall of OBS on a new PC

Glazami commented 3 years ago

This only happens to me with last.fm. Also, the cover does not load in last.fm, and when the settings are applied, obs hangs and crashes

vvouivre commented 3 years ago

This happens to me too.

NichtFireTV commented 3 years ago

Same here

mdsitton commented 3 years ago

Same here

mdsitton commented 3 years ago

Here's the entry from my OBS log file:

13:32:19.882: [tuna] Spotify response: {
13:32:19.882:     "access_token": null,
13:32:19.882:     "error": "invalid_grant",
13:32:19.882:     "error_description": "Invalid authorization code",
13:32:19.882:     "refresh_token": null
13:32:19.882: }
13:32:19.882: 
13:32:19.882: [tuna] Couldn't parse json response!
univrsal commented 3 years ago

I'm fairly certain this is caused by some changes I made to fix #89

univrsal commented 3 years ago

Can you try this build (provided the pipline isn't broken again) and see if the issue is fixed?

ghost commented 3 years ago

Hi, I am also having this problem. I tried at least 4 different releases, and none seem to work. I can't get VLC to work as a source either. Any help is appreciated, just wanna stream some tunes on linux

univrsal commented 3 years ago

I definitely tried the fix on linux and it worked

vvouivre commented 3 years ago

i just tried this fix and it works on my most recently updated windows PC, thanks a lot! i appreciate it very much!

Tipyx commented 3 years ago

Worked too on Windows PC, thanks @univrsal ! (for the fix and the hard work <3)