univrsal / tuna

Song information plugin for obs-studio
GNU General Public License v2.0
733 stars 59 forks source link

MPRIS music cover not fetching properly #201

Closed OriginCode closed 13 hours ago

OriginCode commented 1 week ago

If you're unsure how to properly file a bug report read this. I need as much information as possible otherwise I can't help you and I'm more inclined to just close your issue.

Describe the bug tuna would format the artUrl into something that's not quite right, thus it cannot fetch the correct image. This happens for my setup using a local client (Feishin) to connect to my remote Navidrome streaming server, the url is something like this:

http://xxxx.net/rest/getCoverArt.view?id=xxxxxxxxxxx&u=xxxxxxx&s=xxxxxxxxxxxx&t=xxxxxxxx&v=1.13.0&c=feishin&size=300

The url I get from local webserver is:

http://xxxx.net/rest/getCoverArt.view%3Fid%3Dxxxxxxxxxxxxx%26u%3Dxxxxx%26s%3Dxxxxxx%26t%3Dxxxxxxxxxxxxxxxx%26v%3D1.13.0%26c%3Dfeishin%26size%3D300

Expected behavior Tuna should not re-encode the url string.

univrsal commented 1 week ago

Try this build once it finishes https://github.com/univrsal/tuna/actions/runs/11689705334

OriginCode commented 13 hours ago

Try this build once it finishes https://github.com/univrsal/tuna/actions/runs/11689705334

Yes, this works.