univrsal / tuna

Song information plugin for obs-studio
GNU General Public License v2.0
751 stars 59 forks source link

(MPRIS?) Tuna cant grab cover art if not in file metadata #202

Open space2ninja101 opened 2 weeks ago

space2ninja101 commented 2 weeks ago

If you're unsure how to properly file a bug report read this. I need as much information as possible otherwise I can't help you and I'm more inclined to just close your issue.

Describe the bug A clear and concise description of what the bug is. Tuna cant grab album art if its not in the audio file metadata, I've only tested MPRIS. Suggesting to make Tuna try and grab cover art from an image that is in the directory where the music is played, like how most media players do if it can't find the image in the file metadata. And if possible grab the image from MPRIS data (not sure if thats possible?)

To Reproduce Steps to reproduce the behavior: Play a song without art in the metadata and is instead in the directory of where the music is being played. Use a MPRIS compatible media player. Connect it to Tuna. Make an image source in OBS and point it to the cover art file tuna makes. Placeholder image appears.

Expected behavior A clear and concise description of what you expected to happen. The album art to show.

Screenshots If applicable, add screenshots to help explain your problem.

image

How it looks on the music player and where the cover art is: image You can see it has no trouble grabbing it even if its not in the metadata.

Example of what Tuna currently does (grabs the image from the file metadata as seen in the file thumbnails): image image

Log Add the link to your entire obs studio log

https://obsproject.com/logs/SrzHq71YO5QzODaM

Also add the entire crash report, if this issues is about a crash.

Additional context Add any other context about the problem here.

space2ninja101 commented 2 weeks ago

okay what the fuck? 11:41:10.860: [tuna] Cover file '/run/media/space/c5cea59d-d3e8-44d6-a7ec-52ade28be6f5/Stuff/Music/Bryan%20Scary/bryan-scary/the-shredding-tears/cover.jpg' does not exist it exists though? image

univrsal commented 2 weeks ago

Is the folder also named "Bryan%20Scary" or "Bryan Scary"? Also what player is that?

space2ninja101 commented 2 weeks ago

Is the folder also named "Bryan%20Scary" or "Bryan Scary"? Also what player is that?

the %20 is to indicate its a space the player is gapless aka g4music

univrsal commented 2 weeks ago

the %20 is to indicate its a space

Yes, I am aware of that but it does not answer my question.

space2ninja101 commented 2 weeks ago

the %20 is to indicate its a space

Yes, I am aware of that but it does not answer my question.

its named bryan scary, i thought saying that would make it clear

space2ninja101 commented 2 weeks ago

but the issue isnt that multiple songs have no album art showing because its not in the metadata

univrsal commented 1 week ago

Your issue is probably the same as #201 try this build https://github.com/univrsal/tuna/actions/runs/11689705334