search

unix-thrust / beurk

BEURK Experimental Unix RootKit
GNU General Public License v3.0
362 stars 94 forks source link

Jagu/functionnal #63

Closed jagu-sayan closed 9 years ago

jagu-sayan commented 9 years ago

Please, check if is good for you :tropical_drink:

jagu-sayan commented 9 years ago

More test to come tomorrow.

jagu-sayan commented 9 years ago

BEURK_INSTALL_DIR is defined in our beurk.conf, you can't set it in the Makefile. On another note, "CAREFUL, this command infects[...]" would be more appropriate.

  • mzap
    1. I set BEURK_INSTALL_DIR only in debug mode. This can be an appropriate behavior that this option only work in "production mode". It's the only way I have found to make unit test on make infect and make disinfect. Maybe we need to clarify this behavior in beurk.conf file.
    2. CAREFUL --> done
nil0x42 commented 9 years ago

maybe we can consider changing the variable name from BEURK_INSTALL_DIR into BEURK_INFECT_DIR, it looks more appropriate

jagu-sayan commented 9 years ago

@mzap @chqrly @nil0x42 I rename BEURK_INSTALL_DIR to BEURK_INFECT_DIR. I also add a comment in beurk.conf file: 

-# str: where to store infected
-INSTALL_DIR = /lib
+# str: where to store infected, only work in `production` mode
+INFECT_DIR = /lib
ghost commented 9 years ago

Looks fine, merging now.