search

unixcharles / acme-client

A Ruby client for the letsencrypt's ACME protocol.
MIT License
495 stars 116 forks source link

Travis-ci: added support for ppc64le #197

Closed sanjaymsh closed 3 years ago

sanjaymsh commented 4 years ago

Hi, I have added support for ppc64le build on travis-ci in the branch . The travis-ci build log can be tracked on the link :https://travis-ci.com/github/sanjaymsh/acme-client/builds/199804503 . I believe it is ready for the final review and merge. Please have a look on it.

Thanks !!

jhass commented 4 years ago

What's the benefit of this given this gem contains no platform dependent code itself?

sanjaymsh commented 4 years ago

@jhass This package is included in the distros for ppc64le - we are trying to make sure that integration into the distros is pain free by making sure they have a clean bill of health from their development community. This simplifies the integration process for ppc64le based distros.

Thanks !!

jhass commented 4 years ago

It would be nice if you took the time to answer the question rather than copy pasting your standard reply you posted to a hundred similar pull requests before :)

unixcharles commented 3 years ago

I agree with @jhass here. This Gem is platform independent

If it fail on ppc64le, there is nothing we could do about it. I don't see the point of adding the build.