search

unixcharles / acme-client

A Ruby client for the letsencrypt's ACME protocol.
MIT License
494 stars 117 forks source link

Add EAB support for ssl.com & zerossl.com #210

Closed scrazy77 closed 1 year ago

scrazy77 commented 2 years ago

Add EAB support for ssl.com & zerossl.com. The code is based on https://github.com/unixcharles/acme-client/pull/201 and implement the eab reqeust to ssl.com & zerossl.com. I've tested it and can get certificates.

unixcharles commented 2 years ago

Thanks! I'll need to find time to write automated test but hopefully soon.

jamesooo commented 2 years ago

Hey folks. any update on this one? i'm currently working on adding this in on my application but it'd be great to have this in the gem proper 😄

Shaeli commented 1 year ago

👋 Hi,

Is there any way we could help to move this forward @unixcharles ? I see it's pending on tests being added, I don't mind writing the tests for this feature if needed.

This would also add support for digicert as it requires EAB for authentication. There is another PR adding the same feature: https://github.com/unixcharles/acme-client/pull/219

unixcharles commented 1 year ago

Never got around to write test for it.

I'm not a zerossl user so its a bit difficult for me to test. Normally I test against boulder but I have a digicert account so that might be an option to write some tests. I'll give it a try over the weekend.

If one of you is willing to add test with VCR recording I would be ready to merge directly. I like the implementation.

unixcharles commented 1 year ago

https://github.com/unixcharles/acme-client/pull/221

unixcharles commented 1 year ago

The feature is available in 2.0.13. Let me know if that work for you @scrazy77

scrazy77 commented 1 year ago

thanks , I'll test it this week!