unixcharles / acme-client

A Ruby client for the letsencrypt's ACME protocol.
MIT License
494 stars 117 forks source link

don't include dotfiles in gem #228

Closed danbernier closed 1 year ago

danbernier commented 1 year ago

Fixes #227.

Here's the proof that it works:

dan@nexterday acme-client % git st
On branch exclude-rubocop-yml-from-gem
nothing to commit, working tree clean
dan@nexterday acme-client % gem build
WARNING:  open-ended dependency on bundler (>= 1.17.3, development) is not recommended
  if bundler is semantically versioned, use:
    add_development_dependency 'bundler', '~> 1.17', '>= 1.17.3'
WARNING:  open-ended dependency on webrick (>= 0, development) is not recommended
  use a bounded requirement, such as '~> x.y'
WARNING:  See https://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: acme-client
  Version: 2.0.14
  File: acme-client-2.0.14.gem
dan@nexterday acme-client % mkdir gem_output && tar -xf acme-client-2.0.14.gem -C gem_output
dan@nexterday acme-client % cd gem_output
dan@nexterday gem_output % tar -xf data.tar.gz
dan@nexterday gem_output % ls -a .*
zsh: no matches found: .*
unixcharles commented 1 year ago

I don't mind not packaging dotfiles with the gem in the future but imo this is something your project should fix. If you are vendoring your dependencies into your repository for whatever reason, have rubocop skip them.

danbernier commented 1 year ago

Thanks!

If you are vendoring your dependencies into your repository for whatever reason, have rubocop skip them.

Agreed, but like I said in a comment on the issue:

I tried that, but it still finds the .rubocop.yml in there. My hypothesis is that the logic for finding config files is different from the logic for finding files to lint.

Yeah, though, it's kind of a hash of an issue. Thank you for accepting the PR despite that!