search

unixcharles / acme-client

A Ruby client for the letsencrypt's ACME protocol.
MIT License
494 stars 117 forks source link

get_nonce: Respect connection_options #230

Closed sorah closed 11 months ago

sorah commented 12 months ago

Client#get_nonce doesn't pass @connection_options when generating its own Faraday instance. If connection_options contain a SSL configuration that is required to connect to the endpoint, then Client fails to connect (as nonce is mandatory for ACME requests).

For instance, I have a integration test using https://github.com/letsencrypt/pebble and it comes with self-issued server certificate that has to be trusted to connect.

unixcharles commented 11 months ago

thanks for the PR

unixcharles commented 11 months ago

Its out in 2.0.15