search

unixcharles / refinerycms-copywriting

Refinery CMS engine to manage copywriting, application wide or per pages with i18n.
53 stars 42 forks source link

Used the same phrase name value in the form as in the index #60

Closed gwagener closed 10 years ago

gwagener commented 10 years ago

https://github.com/unixcharles/refinerycms-copywriting/blob/master/app/views/refinery/copywriting/admin/phrases/_phrase.html.erb#L6 does not capitalize the phrase name. The problem with capitalize is that it will make any other words lowercase. For instance "My URL" becomes "My url".

parndt commented 10 years ago

Is it worth adding a test for this?

gwagener commented 10 years ago

I don't think so. You'd basically have a full feature test that has to load the page and test if the bit is equal to phrase.name. It doesn't add significant confidence while adding significantly to testing time.