search

unixorn / ha-mqtt-discoverable

Python module to create MQTT entities that are automatically discovered by Home Assistant
Apache License 2.0
89 stars 21 forks source link

Pydantic V2.0 bump? #175

Closed leogaggl closed 3 months ago

leogaggl commented 7 months ago

Is your feature request related to a problem? Please describe. I would love to include this library in one of my projects which proxies a local MQTT server to the outside. However, there is a dependency clash on Pydantic as fastapi-mqtt (^2.1.0) and ha-mqtt-discoverable (^0.13.1) can not agree on the Pydantic version. And the other project requires V2.

Describe the solution you'd like It would be great if the version could be bumped. I can already see a PR from dependabot --> https://github.com/unixorn/ha-mqtt-discoverable/pull/174

It would be great if that could be merged so the the library can be included.

unixorn commented 7 months ago

I haven't had time to test the PR - I'm going to try and look at it this weekend. It's a major version bump and I don't want to break things by merging it.

leogaggl commented 7 months ago

Thank you! That would be great and much appreciated.

No major urgency - but it beats implementing this functionality by hand. Not into re-inventing wheels.

unixorn commented 3 months ago

Closed by #191

Sorry this took so long, I broke my ankle in October and am still doing physical therapy after the surgery, so I didn't have time to confirm that things still worked.

leogaggl commented 3 months ago

Thanks for the update!

No worries at all. I hope your ankle gets better soon!

Keep up the good work. Appreciate the library!

unixorn commented 3 months ago

Thank you! I'm glad to hear it is helpful.