search

unixporn / trup

Discord bot for the Unixporn community
Mozilla Public License 2.0
47 stars 9 forks source link

Added Host[Device Name] To !fetch #151

Closed ghost closed 3 years ago

ghost commented 3 years ago

So that people can set whatever device they are using

eepykate commented 3 years ago

1.

image

  1. This will just spit an error 2 errors on non-linux systems, right in the middle of the fetch output.
ghost commented 3 years ago

i think i can fix that

Tanish2002 commented 3 years ago

As you can see from the build output you didn't change db/sysinfo.go to support Host look at this pull request for reference https://github.com/unixporn/trup/pull/143/files

eepykate commented 3 years ago

Damn they write some nice code, can i get in touch?

ghost commented 3 years ago

Fixed everything :)

eepykate commented 3 years ago

Sounds like there's no easy way about cleanly detecting the model.

# example format
product_name | product_version

# smokin   (laptop)
## HP made their own placeholder, not sure how many others have done this, 
##  sounds like there will be a million edge cases
HP Pavilion Notebook | Type1ProductConfigId
# tanish   (laptop)
## order is wack
82EY | IdeaPad Gaming3 15ARH05D
# me   (desktop)
##  "Default string" is easy enough to remove since it seems to be global
H110M-H | Default string
# ladle   (desktop)
## seems reasonable enough
MS-7C02 | 1.0