unixporn / trup

Discord bot for the Unixporn community
Mozilla Public License 2.0
47 stars 9 forks source link

change fetcher.sh script to use neofetch #26

Closed mlvzk closed 4 years ago

mlvzk commented 4 years ago

neofetch --json neofetch --stdout

eepykate commented 4 years ago

neofetch cringe

no

disagree

bad

eepykate commented 4 years ago

(also you might want to use --config=/dev/null to remove any user modifications)

DRG-developer commented 4 years ago

That would require users to install neoflex, i am against it too. Not everyone has neoflex, (i don't for example), but, a —neofetch option, that would be a viable thing? Or just neofetcher,sh which uses neofetch.

The real question i have is: why should we switch?

aosync commented 4 years ago

That would require users to install neoflex, i am against it too. Not everyone has neoflex, (i don't for example), but, a —neofetch option, that would be a viable thing? Or just neofetcher,sh which uses neofetch.

I am not for, not against, but just a little note that if we adopt that, we could tell users to curl into bash, even if that sounds a bit sketchy.

The URL to neofetch is quite legit enough though, so that'd be ok in that case.

eepykate commented 4 years ago

@DRG-developer You won't have to install neofetch? curl url | bash exists.

a —neofetch option, that would be a viable thing

Absolutely not, then what would the point be? Then we'd still have to work on this script, but we'd also have to make sure trup is compatible with both the way neofetch and fetcher.sh print out the information

The real question i have is: why should we switch?

Less maintaining, it's all been done for us. Plus neofetch supports almost every OS under the sun, this script only supports linux, and not even every linux distro.

exorcist365 commented 4 years ago

the entire issue is useless so just close it?!

eepykate commented 4 years ago

@exorcist-gif Why?

It's a valid issue. If we switch to neofetch we wouldn't need to work on it anymore, since neofetch already supports almost every OS ever. And again, this script only supports linux, and not even every linux distro. (oh wait and macos too, idk how good the support for that is tho)

DRG-developer commented 4 years ago

@GaugeK Then i am for calling this script “finished” and for new features you have to use neoflex, and if it's incompatible with your OS or you use some obscure os like artix you need to use neofetch. Just so we don't have to force neofetch upon users

I am 100% against using curl to get neofetch and then executing that. I do see the point you're making though

I might try a PoC neofetcher.sh in some time

eepykate commented 4 years ago

I am 100% against using curl to get neofetch and then executing that.

How is that different than curl fetcher.sh | sh? That's exactly what the bot says to do with the current script.

DRG-developer commented 4 years ago

Yes, might as well edit that while we're at it, that's very weird, cause it does tell you to read it. Change it to curl link.com/fetcher.sh -o fetcher.sh, verify the script, and then just execute it (chmod +x fetcher.sh && ./fetchersh

aosync commented 4 years ago

No, that's dumb.

ghost commented 4 years ago

If you are against using curl to run neofetch, just fork the repo and make changes here. Then you can just implement all the features, specifically the distro based ones, from neofetch into the fetcher script.