search

unixwork / xnedit

A fast and classic X11 text editor, based on NEdit, with full unicode support and antialiased text rendering.
Other
82 stars 12 forks source link

Missing column sort arrow on second invocation of FSB in detail view #122

Closed dpeterc closed 1 year ago

dpeterc commented 1 year ago

I use the fileselection box (FSB) in detail view. On the first invocation, program correctly displays the default sort order by name, indicated by the top-down arrrow. xnedtiFSB1 Then I click on the size button, and arrow moves and indicated the new sorting direction. xnedtiFSB2 If I then close the window, and reopen it, previous sort order is maintained (as it is correct), but the arrow button is not displayed. xnedtiFSB3 This can be confusing to users, as there is no visual cue of the current sort order.

unixwork commented 1 year ago

The arrow is now always visible.

But I actually see another bug, when the FSB is opened again, the "Files" label is not really visible.

dpeterc commented 1 year ago

Indeed; that is quite strange as even a window resize does not fix that. The second invocation of FSB in detail view can now look even worse, where part of the list is not redrawn properly as well. xnedtiFSB4 This is fixed with window resize (or click on invisible columns). But first impression is not actually worse on my computer. It looks like premature refresh, while geometry negotiations were not finished yet. Or one missing refresh at the end.

unixwork commented 1 year ago

I have disabled some changes from the last commit. Can you check if this fixes the redraw problem of the grid widget?

dpeterc commented 1 year ago

The redraw problem is fixed with your last commit, thank you very much. The problem of missing label "Files" remains, but it is a minor issue.

unixwork commented 1 year ago

The label bug is also fixed now.

dpeterc commented 1 year ago

Tested and confirmed! Thanks for being so responsive.