unjs / consola

๐Ÿจ Elegant Console Logger for Node.js and Browser
Other
5.78k stars 165 forks source link

build: fix subpath types #265

Closed shinGangan closed 6 months ago

shinGangan commented 6 months ago

๐Ÿ”— Linked issue

resolved #239 .

โ“ Type of change

๐Ÿข Environment

$ npm ls | grep consola
โ”œโ”€โ”€ consola@3.2.3

๐Ÿ“š Description

I installed and used consola and got TS2307 error with the following two.

The following worked correctly.

Checked installed modules, basic.d.ts and browser.d.ts were not included.

$ ls node_modules/consola    
LICENSE         core.d.ts       lib             utils.d.ts
README.md       dist            package.json

Checked the exports field in package.json and found that the file names were different. This PR was fixed this.

๐Ÿ“ Checklist

shinGangan commented 6 months ago

Hi @pi0 .

I would appreciate it if you could approve the workflows and review when you have time.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (90d4807) 61.13% compared to head (26c37d1) 61.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #265 +/- ## ======================================= Coverage 61.13% 61.13% ======================================= Files 13 13 Lines 1379 1379 Branches 58 58 ======================================= Hits 843 843 Misses 536 536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shinGangan commented 6 months ago

@pi0, thanks for the merge.

Glad to contribute to unjs. I hope to continue to contribute where I can.