fix(parser): be able to support cookies with no value (defaults true) - Githubissues

unjs / cookie-es

🍪 Cookie and Set-Cookie parser and serializer

Other

151 stars 10 forks source link

fix(parser): be able to support cookies with no value (defaults true) #24

Closed rishi-raj-jain closed 5 months ago

rishi-raj-jain commented 7 months ago

🔗 Linked issue

fixes #17

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In this PR, I update the logic to default to true for all the keys that do not have a value associated with them.

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

pi0 commented 5 months ago

Thanks for this PR. While this allows supporting Set-Cookie format in some sort, it won't be spec compliant since the Cookie parsing is different.

I've made a new proposal lets track via https://github.com/unjs/cookie-es/issues/33