chore: use optional chaining

ferferga commented 11 months ago

🔗 Linked issue

Review comments from #104

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[X] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Refer to @pi0 in this comment. I think the optional chaining it's still relevant.

📝 Checklist

[X] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

pi0 commented 10 months ago

Thanks for splitting this part of the change. Can you please remind me why this change was required? Purely for code readability?

ferferga commented 10 months ago

@pi0 Yes, exactly.

pi0 commented 10 months ago

Ah, thanks for confirming. If this is only the case, I think it might be better to keep it as is.

I also really want to get rid of legacy syntaxes and prefer new ones but optional chaining can be particularly tricky to use especially in defu which is used in many many different projects. Many of them use Nuxt 2 with webpack 4 which does not understand this syntax (natively) as it uses older acorn parser even tough all recent browsers support it.

unjs / defu