search

unjs / defu

🌊 Assign default properties recursively
MIT License
1.06k stars 22 forks source link

chore: add homepage in package.json #40

Closed navarroaxel closed 2 years ago

navarroaxel commented 2 years ago

Fix the repository handling in package.json based on the official doc page: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

Add the homepage link to the repository based on https://docs.npmjs.com/cli/v6/configuring-npm/package-json#homepage

navarroaxel commented 2 years ago

Note to the maintainers: you can change the Fork pull request workflows from outside collaborators setting here https://github.com/unjs/defu/settings/actions

from Require approval for first-time contributors to Require approval for first-time contributors who are new to GitHub, to skip the requirement to approve the run for the GH action to non-new GH users.

pi0 commented 2 years ago

Thanks for PR @navarroaxel. But as you can spot in the linked docs, shortcut syntax is also supported and I prefer smaller package.json to be shipped:

image
navarroaxel commented 2 years ago

Thanks for PR @navarroaxel. But as you can spot in the linked docs, shortcut syntax is also supported and I prefer smaller package.json to be shipped:

@pi0 then why the repository link is not listed in the npm page for this package? :thinking:

repository link example

Maybe the homepage link is required to display the repository link. I always see both links.

pi0 commented 2 years ago

I'm aware. Sadly this is a recent UI change that stopped npm from showing using shorthand syntax. And wasn't requiring homepage either. Let me do a quick research if it is an intentional change by npm and if it is, we need to update dozens of unjs repos at least :}

pi0 commented 2 years ago

Hi @navarroaxel. I think finally npm folks resolved the issue to show homepage with repository shorthand field. It fixed after recent npm publish.

BTW thanks for caring to make this <3

image