Closed michaeltaranto closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.01%. Comparing base (
7fea517
) to head (e8bc9e3
). Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It doesnt seem like the codecov bot has run since the action was updated, resulting in this PR showing a failed result π€ .
π Linked issue
First step relating to this discussion.
Closes https://github.com/unjs/fontaine/pull/317 and https://github.com/unjs/fontaine/pull/318 (auto-generated PRs)
β Type of change
Open to discussing this one, selecting
chore
for now.π Description
Upgrading to the latest Capsize packages. This upgrade provides a few key benefits to the Fontaine π€ Capsize relationship:
moduleResolution
strategy that understands the package.jsonexports
key, e.g.Bundler
.xWidthAvg
metric, now calculated from more extendable dataset (rather than hard coded English character frequencies) in preparation for supporting other unicode subsets, e.g. Thai. This is a move away from the original character frequencies collaborated on with the Google Aurora team, and seem to perform same or better, while also having the benefit of no longer being hard coded. As a result the snapshots of metrics and CSS have changed, but here is a visual example of the change to IBM Plex Mono (used in one of the snapshots):No Capsize:
With Capsize v1:
With Capsize v2:
Note also upgrading to Node 18 in CI due to missing
fetch
API. Hopefully thats ok given Node 16s move to EOLπ Checklist