fix: explicit `port/portRange` even if `random` is `true` - Githubissues

unjs / get-port-please

🔌 Get an available open port

MIT License

245 stars 12 forks source link

fix: explicit `port/portRange` even if `random` is `true` #69

Closed peterroe closed 8 months ago

peterroe commented 11 months ago

🔗 Linked issue

https://github.com/unjs/get-port-please/issues/65

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

pi0 commented 8 months ago

Thanks for PR. linked issue should be resolved by https://github.com/unjs/get-port-please/commit/cd4acec1245c7241000cd88f623192709574a370 in next release.