unjs / get-port-please

๐Ÿ”Œ Get an available open port
MIT License
255 stars 13 forks source link

fix: improve log when using alternative port #78

Closed danielroe closed 10 months ago

danielroe commented 10 months ago

๐Ÿ”— Linked issue

โ“ Type of change

๐Ÿ“š Description

This no longer logs if an empty array is passed in portsToCheck, and also corrects the log message so it doesn't say that it failed to find a port in the range that did produce a port.

๐Ÿ“ Checklist

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2ff49d5) 85.45% compared to head (e394270) 85.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================== + Coverage 85.45% 85.56% +0.11% ========================================== Files 5 5 Lines 385 388 +3 Branches 50 51 +1 ========================================== + Hits 329 332 +3 Misses 56 56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielroe commented 10 months ago

@pi0 There seems to be a flakey test, FYI. Latest commit passes with no code changes compared to previous failure. Maybe we could increase timeout? ๐Ÿค”