Closed nick-genesis closed 11 months ago
Shouldn't make a difference, tested with Node v18.15.0
Attempt a download of any git branch that includes slashes.
The ref capturing group of inputRegex used by parseGitURI is too strict, does not include /. This can result in failed download attempts.
inputRegex
parseGitURI
/
This might not technically be a bug, but there's no downside to adjusting the regex to allow slashes afaik.
technically
It would be nice to get this working as org/repo#user/ABC-123 is a pretty common pattern.
org/repo#user/ABC-123
I have adjusted the regex and added a test for it, only opening this issue to reference it in the PR.
Resolved by https://github.com/unjs/giget/pull/102
No response
Environment
Shouldn't make a difference, tested with Node v18.15.0
Reproduction
Attempt a download of any git branch that includes slashes.
Describe the bug
The ref capturing group of
inputRegexused byparseGitURIis too strict, does not include/. This can result in failed download attempts.This might not
technicallybe a bug, but there's no downside to adjusting the regex to allow slashes afaik.It would be nice to get this working as
org/repo#user/ABC-123is a pretty common pattern.Additional context
I have adjusted the regex and added a test for it, only opening this issue to reference it in the PR.
Resolved by https://github.com/unjs/giget/pull/102
Logs
No response