unjs / giget

✨ Download templates and git repositories with pleasure!
MIT License
446 stars 37 forks source link

fix: adjusting regex to allow `/` in git refs #102

Closed nick-genesis closed 11 months ago

nick-genesis commented 1 year ago

πŸ”— Linked issue

101

❓ Type of change

πŸ“š Description

Allow parseGitURI to correctly parse git refs that include slashes.

This is a pretty common pattern org/repo#username/ABC-123 which does not currently get parsed correctly as the ref capturing group in the regex is too strict.

Resolves #101

πŸ“ Checklist

nick-genesis commented 1 year ago

@pi0 have you had a chance to look at this by any chance? Would be great if we could get it merged soon, thanks!

nick-genesis commented 11 months ago

@pi0 thanks for approving, will you be merging this soon? Let me know if you need anything else from my side.

codecov[bot] commented 11 months ago

Codecov Report

Merging #102 (e4a9316) into main (5ea5d96) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files           6        6           
  Lines         442      442           
  Branches       43       43           
=======================================
  Hits          316      316           
  Misses        126      126           
Files Coverage Ξ”
src/_utils.ts 75.36% <100.00%> (ΓΈ)