unjs / giget

โœจ Download templates and git repositories with pleasure!
MIT License
425 stars 37 forks source link

fix(cli): display the current directory when cloning into current dir #132

Closed uncenter closed 7 months ago

uncenter commented 7 months ago

โ“ Type of change

๐Ÿ“š Description

The success message after cloning a template into the current directory is a little confusing:

Screenshot 2023-12-23 at 15 49 58 (kitty)

Where was it cloned? Did it work?

Not sure if this is the ideal solution for y'all but with this PR it looks like this instead:

Screenshot 2023-12-23 at 15 52 52 (kitty)

๐Ÿ“ Checklist

uncenter commented 7 months ago

As you suggested, looks like this now:

Screenshot 2023-12-23 at 16 14 56 (kitty)

uncenter commented 7 months ago

Yep, that works. One less process.cwd() call!

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb82386) 54.80% compared to head (a95f9d8) 54.93%. Report is 2 commits behind head on main.

Files Patch % Lines
src/cli.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================== + Coverage 54.80% 54.93% +0.13% ========================================== Files 7 7 Lines 604 608 +4 Branches 46 47 +1 ========================================== + Hits 331 334 +3 - Misses 272 273 +1 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.