unjs / giget

โœจ Download templates and git repositories with pleasure!
MIT License
425 stars 37 forks source link

fix(parseGitURI): support `@` symbol in ref segment #153

Closed matthewvolk closed 4 months ago

matthewvolk commented 4 months ago

๐Ÿ”— Linked issue

152

โ“ Type of change

๐Ÿ“š Description

Adds support for @ characters in parseGitURI's inputRegex.

Since the @ character is not included in the <ref> character set [\w./-], tags containing @ won't be matched by this pattern, and will fallback to main. See linked issue for more detail.

Resolves #152

๐Ÿ“ Checklist

matthewvolk commented 4 months ago

Hi @pi0 ๐Ÿ™‚

Wondering if I could bug you for a quick review on this one. As an additional note, when you approve the workflow runs, they might fail due to node-fetch-native being 1.6.2 โ€”ย I noticed that downgrading to 1.6.1 fixes the errors. Let me know if you'd like a separate PR for that ๐Ÿ™

Thanks in advance!