search

unjs / giget

✨ Download templates and git repositories with pleasure!
MIT License
446 stars 37 forks source link

feat: add tar provider, more tests, adjust vitest config #86

Closed alex-key closed 8 months ago

alex-key commented 1 year ago

Should resolve #10

@pi0 I had to change proposed pattern to replace &=version with #version. Ampersand (&) could be evaluated by most terminals as next command if you do not wrap in quotes. So I propose to use [url]#name=[name]#version=[version]. Though I am not sure if version is really needed and useful. See my comment in the diff.

Jupa8i commented 1 year ago

When will you be in master?

alex-key commented 1 year ago

When will you be in master?

@pi0 kind reminder to review. Let me know if any adjustments are needed

pi0 commented 8 months ago

Hi dear @alex-key thanks for working on this PR and sorry it got stalled for a while.

I have worked on a slightly different approach to support generic HTTP(s) sources as either JSON provider or direct tar provider (#129)

As for tests, they are really nice additions. There are couple of merge conflicts now wasn't sure if you prefer to still pick it to rebase or not but moved to the issue #https://github.com/unjs/giget/issues/130 please ping to assign if you still like to help on improving test coverage!