unjs / ipx

πŸ–ΌοΈ High performance, secure and easy-to-use image optimizer.
MIT License
1.2k stars 59 forks source link

feat: upgrade to sharp 0.33 with installation enahancenments #190

Closed pi0 closed 5 months ago

pi0 commented 8 months ago

πŸ”— Linked issue

https://github.com/lovell/sharp/issues/3750

❓ Type of change

πŸ“š Description

This PR is a preview for sharp@0.33 alpha releases with the removal of the install script and dedicated per-arch packages + experimental WASM package πŸ₯³ (note: It is still Node.js only. Workers without thread support do not work!)

See https://github.com/lovell/sharp/issues/3750 for more details.

πŸ§ͺ Try via nightly channel

Preview is published under ipx-nightly release channel.

Method 1: If you are directly using ipx as a dependency, change package.json dependency to use npm:ipx-nightly@latest as version.

{
  "dependencies": {
--    "ipx": "latest",
++    "ipx": "npm:ipx-nightly@latest",
  }
}

Method 2: If you are indirectly using ipx You can add resolutions field in package.json to override the package:

{
  "resolutions": {
    "ipx": "npm:ipx-nightly@latest"
  }
}

Important: See https://github.com/nuxt/image/pull/1102 for Nuxt image instructions

πŸ› Issues

CI seems to be passing well. I have discovered some issues with https://github.com/nuxt/image/pull/1102 which are unrelated.

πŸ“ Checklist

codecov[bot] commented 8 months ago

Codecov Report

Merging #190 (9dcb0be) into main (675ab59) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   54.10%   54.10%           
=======================================
  Files          11       11           
  Lines        1083     1083           
  Branches       45       45           
=======================================
  Hits          586      586           
  Misses        497      497           
DavidDeSloovere commented 6 months ago

Just wanted to let you know that sharp 0.33.0 has been released (there already a 0.33.1). Was looking at this hoping CF Workers/Pages would work, but I now know that the lack of thread support is blocking.

pi0 commented 5 months ago

Merged in main for ipx v3