fix: add default `300` maxAge for http adapter

jameswragg commented 7 months ago

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The README specified the IPX_HTTP_MAX_AGE default to be 300 but its never set (as a default).

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fc8a0de) 54.10% compared to head (65be210) 54.10%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #197 +/- ## ======================================= Coverage 54.10% 54.10% ======================================= Files 11 11 Lines 1083 1083 Branches 45 45 ======================================= Hits 586 586 Misses 497 497 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jameswragg commented 7 months ago

FYI @pi0 I don't have merge permissions

pi0 commented 7 months ago

Yeah will merge once planned for release otherwise will forget about PR :)

unjs / ipx