unjs / ipx

๐Ÿ–ผ๏ธ High performance, secure and easy-to-use image optimizer.
MIT License
1.2k stars 59 forks source link

fix(server): remove query params from image id #206

Closed Ayax0 closed 5 months ago

Ayax0 commented 6 months ago

๐Ÿ”— Linked issue

205

โ“ Type of change

๐Ÿ“š Description

The query parameters are removed from the image url to allow further information relevant to the server to be provided via query parameters. Resolves #205

๐Ÿ“ Checklist

pi0 commented 5 months ago

Thanks for spending time on this PR. I have explained little more in https://github.com/unjs/ipx/issues/205#issuecomment-1888125699 I think it should be really common and also opt-in behavior to strip query params like this from source.

For now closing PR (mainly for triage) but would love to discuss and reconsider this change.